Add the necessary steps for lucene replace #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I'm not sure is the lock, two write locks together, not sure if it will work |
|
We need more tests for this, but that was true before. This fix seems right to me. |
michael-mclawhorn
previously approved these changes
Oct 13, 2017
QubitPi
suggested changes
Oct 13, 2017
| @@ -191,6 +192,7 @@ class LuceneSearchProviderSpec extends SearchProviderSpec<LuceneSearchProvider> | |||
| !Files.exists(file4) | |||
| } | |||
|
|
|||
| @Ignore("This test is currently not valid because the replacement index is invalid.") | |||
There was a problem hiding this comment.
This shouldn't seem to be ignored, 'cause it was working previously
There was a problem hiding this comment.
It no longer works, because the file we are using is fake, the method now requires a real index file
|
Given this needs to be addressed in a separate PR, #552, I'm OK with it |
QubitPi
previously approved these changes
Oct 13, 2017
michael-mclawhorn
dismissed stale reviews from QubitPi and themself
via
cc2c619
michael-mclawhorn
previously approved these changes
Oct 13, 2017
There was a problem hiding this comment.
I wish I had a test plan to propose. @QubitPi is planning to look into it.
michael-mclawhorn
force-pushed
the
FixReplace
branch
from
cc2c619 to
503cdca
Compare
michael-mclawhorn
previously approved these changes
Oct 13, 2017
QubitPi
previously approved these changes
Oct 13, 2017
garyluoex
dismissed stale reviews from QubitPi and michael-mclawhorn
via
f2ffbca
garyluoex
force-pushed
the
FixReplace
branch
2 times, most recently
from
ad97746 to
503cdca
Compare
michael-mclawhorn
approved these changes
Oct 16, 2017
QubitPi
approved these changes
Oct 16, 2017
|
Thanks @michael-mclawhorn. Test will be my next urgent thing to do #552 |
This was referenced Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.