Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with wrong time offset calculation #567

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

QubitPi
Copy link
Contributor

@QubitPi QubitPi commented Nov 7, 2017

Time-checking based tests setup time offset in a wrong way. timeZoneId.getOffset is fixed to take the right argument.

@QubitPi
Copy link
Contributor Author

QubitPi commented Nov 7, 2017

Thanks, @asifmansoora !

@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch 2 times, most recently from 41646ac to aca4db0 Compare November 7, 2017 19:47
@QubitPi QubitPi changed the title Fix test failure due to daylight saving Fix tests with wrong time offset calculation Nov 7, 2017
@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch from aca4db0 to 8f8fcb7 Compare November 7, 2017 19:48
@yahoo yahoo deleted a comment Nov 7, 2017
@yahoo yahoo deleted a comment Nov 7, 2017
@yahoo yahoo deleted a comment Nov 7, 2017
@yahoo yahoo deleted a comment Nov 7, 2017
@yahoo yahoo deleted a comment Nov 7, 2017
@yahoo yahoo deleted a comment Nov 7, 2017
@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch from 9e00c0a to dc23c48 Compare November 8, 2017 16:00
@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch from c3efd42 to 5649eb1 Compare November 8, 2017 16:02
@QubitPi
Copy link
Contributor Author

QubitPi commented Nov 8, 2017

Thanks, @archolewa !

@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch from e88603f to a1498f1 Compare November 8, 2017 16:05
@QubitPi QubitPi force-pushed the fix-test-failure-due-to-daylight-saving branch from a86b5ac to 7afe4d0 Compare November 8, 2017 16:06
@QubitPi QubitPi merged commit b284559 into master Nov 8, 2017
@QubitPi QubitPi deleted the fix-test-failure-due-to-daylight-saving branch November 8, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants