Expose RequestLog's LogInfo objects. #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
approved these changes
Nov 10, 2017
|
@archolewa Build will pass after a rebase |
|
A small CHANGELOG would not be inappropriate. |
archolewa
force-pushed
the
enrich-requestlog
branch
from
cee3ade to
921963c
Compare
|
@michael-mclawhorn Addressed your comment. |
michael-mclawhorn
approved these changes
Nov 15, 2017
added 2 commits
November 16, 2017 09:17
-- Some customers want to be able to customize how the RequestLog is logged. By exposing the LogInfo objects and the durations, we effectively give customers full control over how they want to log each component of the RequestLog.
archolewa
force-pushed
the
enrich-requestlog
branch
from
6542596 to
ac98103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Some customers want to be able to customize how the RequestLog is
logged. By exposing the LogInfo objects and the durations, we
effectively give customers full control over how they want to log
each component of the RequestLog.