Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TimeFormatExtractionFunction #611

Merged
merged 11 commits into from
Jan 12, 2018
Merged

Implement TimeFormatExtractionFunction #611

merged 11 commits into from
Jan 12, 2018

Conversation

QubitPi
Copy link
Contributor

@QubitPi QubitPi commented Jan 10, 2018 •
edited
Loading

Enable TimeFormatExtractionFunction in Fili so that API users could interact with Druid using TimeFormatExtractionFunction through Fili.

garyluoex
garyluoex requested changes Jan 12, 2018
View reviewed changes
Copy link
Collaborator

@garyluoex garyluoex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use groovy console and use jackson object mapper to serialize one of this thing, so that we know the serialization is correct.

@yahoo yahoo deleted a comment Jan 12, 2018
michael-mclawhorn
michael-mclawhorn approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@michael-mclawhorn michael-mclawhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Gary's request for actual serialization testing. Otherwise good to go.

@QubitPi
Copy link
Contributor Author

QubitPi commented Jan 12, 2018

Thanks @michael-mclawhorn and @garyluoex . I've added the tests in TimeFormatExtractionFunctionSpec

@QubitPi QubitPi merged commit 03a5144 into master Jan 12, 2018
@QubitPi QubitPi deleted the Implement-TimeFormatExtractionFunction branch January 12, 2018 21:06
@QubitPi QubitPi mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyluoex garyluoex garyluoex approved these changes

@michael-mclawhorn michael-mclawhorn michael-mclawhorn approved these changes

Assignees
No one assigned
Labels
MERGEABLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QubitPi @michael-mclawhorn @garyluoex