Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let DimensionApiRequestMapper throw RequestValidationException instead of BadApiRequestException #715

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Let DimensionApiRequestMapper throw RequestValidationException instead of BadApiRequestException #715

merged 2 commits into from
Jun 29, 2018

Conversation

QubitPi
Copy link
Contributor

@QubitPi QubitPi commented Jun 6, 2018

Addresses issue #714

@QubitPi QubitPi force-pushed the issue-714-let-DimensionApiRequestMapper-throw-RequestValidationException-instead-of-BadApiRequestException branch from 8561577 to f403723 Compare June 6, 2018 20:48
cdeszaq
cdeszaq approved these changes Jun 7, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -15,6 +15,10 @@ pull request if there was one.

### Changed:

- [Let DimensionApiRequestMapper throw RequestValidationException instead of BadApiRequestException](https://github.com/yahoo/fili/pull/715)
* `DimensionApiRequestMapper.apply()` is made to obey the interfact contract by throwing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/interfact/interface

@QubitPi
Copy link
Contributor Author

QubitPi commented Jun 7, 2018

Thanks for the review & approval, @cdeszaq !

@QubitPi QubitPi force-pushed the issue-714-let-DimensionApiRequestMapper-throw-RequestValidationException-instead-of-BadApiRequestException branch from 910a9a2 to 45b8f5a Compare June 29, 2018 04:29
@QubitPi QubitPi merged commit 387b596 into master Jun 29, 2018
@QubitPi QubitPi deleted the issue-714-let-DimensionApiRequestMapper-throw-RequestValidationException-instead-of-BadApiRequestException branch June 29, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdeszaq cdeszaq cdeszaq approved these changes

Assignees
No one assigned
Labels
BUG DEBUG MERGEABLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QubitPi @cdeszaq