Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "case_sensitive" attribute in FragmentSearchQuerySpec #727

Merged
merged 3 commits into from
Jul 13, 2018

Conversation

QubitPi
Copy link
Contributor

@QubitPi QubitPi commented Jun 25, 2018

FragmentSearchQuerySpec has an attributed called case_sensitive that has not been configurable in Druid yet. This PR adds it so that API users can configure it through Fili.

In addition, there is not test spec specifically for FragmentSearchQuerySpec. This PR adds the tests for it as well.

@QubitPi QubitPi changed the title Add support for 'case_sensitive' attribute in FragmentSearchQuerySpec Add support for "case_sensitive" attribute in FragmentSearchQuerySpec Jun 25, 2018
@QubitPi QubitPi force-pushed the add-case-sensitive-attribute-in-frag-search-query branch from de0fc22 to 5179995 Compare June 25, 2018 13:14
@yahoo yahoo deleted a comment Jun 25, 2018
Copy link
Contributor

@michael-mclawhorn michael-mclawhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane and appropriate.

@yahoo yahoo deleted a comment Jul 12, 2018
@yahoo yahoo deleted a comment Jul 13, 2018
@QubitPi QubitPi merged commit 39678fd into master Jul 13, 2018
@QubitPi QubitPi deleted the add-case-sensitive-attribute-in-frag-search-query branch July 13, 2018 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants