Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can now inject a subclass of DruidQueryBuilder. #98

Merged
merged 1 commit into from
Nov 17, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Current

### Fixed:

- [Made a few injection points not useless](https://github.com/yahoo/fili/pull/98)
* Template types don't get the same subclass goodness that method invocation and
dependencies get, so this method did not allow returning a subclass of
`DruidQueryBuilder` or of `DruidResponseParser`.


### Known Issues:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ protected void configure() {
*
* @return An isntance of the {@link DruidQueryBuilder}
*/
protected Class<DruidQueryBuilder> buildDruidQueryBuilder() {
protected Class<? extends DruidQueryBuilder> buildDruidQueryBuilder() {
return DruidQueryBuilder.class;
}

Expand All @@ -343,7 +343,7 @@ protected Class<DruidQueryBuilder> buildDruidQueryBuilder() {
*
* @return An instance of the {@link DruidResponseParser}
*/
protected Class<DruidResponseParser> buildDruidResponseParser() {
protected Class<? extends DruidResponseParser> buildDruidResponseParser() {
return DruidResponseParser.class;
}

Expand Down