Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react dep, move mockExecuteAction to avoid context warning #12

Merged
merged 4 commits into from
Mar 18, 2015

Conversation

ZeikJT
Copy link
Contributor

@ZeikJT ZeikJT commented Mar 17, 2015

@koulmomo
Support React@0.13 or React@0.12

Had to update my test helper so that we wouldn't get erroneous warnings about context owner vs parent (stems from the fact that React calls getChildContext twice and looks for mismatches and since my function was nested it would create two different functions)

@yahoocla
Copy link

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 21438d0 on upgrade/react-13 into 5b0a6b5 on master.

koulmomo added a commit that referenced this pull request Mar 18, 2015
Bump react dep, move mockExecuteAction to avoid context warning
@koulmomo koulmomo merged commit 80f2598 into master Mar 18, 2015
@koulmomo
Copy link
Contributor

@ZeikJT I want to upgrade some more deps/devDeps before publishing a releasing

@koulmomo koulmomo deleted the upgrade/react-13 branch March 18, 2015 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants