-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modularize async utils #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re utils. ✅ add new unit test(s) for modularized exports + getTasksForAsync method (which was broken out to /internals/getTasksForAsync).
CLA is valid! |
Anything under the |
koulmomo
changed the title
[breaking changes][refactor] modularize async utils
[refactor] modularize async utils
Mar 3, 2015
1 similar comment
This looks good to me @koulmomo 👍 💯 |
Also I don't see why this can't lead to a 1.0 bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akshayp @ZeikJT
As discussed, this refactor modifies the API and moves all methods that used to be accessible under the root package, to
require('fluxible-action-utils').async
as well as allow for modularized requires.#8 should be refactored to follow the new exports/directory structure presented here, and only merged after this PR. Will then release both as part of a
0.2.0
release.New modularized API
🎨 refactor codebase to support modularized API and the addition of more utils.
✅ add new unit test(s) for modularized exports + getTasksForAsync method (which was broken out to /internals/getTasksForAsync).