Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularize async utils #9

Merged
merged 3 commits into from
Mar 3, 2015
Merged

Conversation

koulmomo
Copy link
Contributor

@koulmomo koulmomo commented Mar 3, 2015

@akshayp @ZeikJT

As discussed, this refactor modifies the API and moves all methods that used to be accessible under the root package, to require('fluxible-action-utils').async as well as allow for modularized requires.

#8 should be refactored to follow the new exports/directory structure presented here, and only merged after this PR. Will then release both as part of a 0.2.0 release.

New modularized API

var utils = require('fluxible-action-utils');  // returns { async: ... };
var asyncUtils = require('fluxible-action-utils/async'); // returns {executeCritical: ..., executeMultiple: ..., ...}

ustils.async === asyncUtils // true!

var executeMultiple = require('fluxible-action-utils/async/executeMultiple');
(utils.async.executeMultiple === asyncUtils.executeMultiple) && 
(utils.async.executeMultiple === executeMultiple) // true!

// ...

🎨 refactor codebase to support modularized API and the addition of more utils.
✅ add new unit test(s) for modularized exports + getTasksForAsync method (which was broken out to /internals/getTasksForAsync).

…re utils.

✅ add new unit test(s) for modularized exports + getTasksForAsync method (which was broken out to /internals/getTasksForAsync).
@yahoocla
Copy link

yahoocla commented Mar 3, 2015

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3f601d9 on refactor/modularize-async-methods into 3d2f6f0 on master.

@koulmomo
Copy link
Contributor Author

koulmomo commented Mar 3, 2015

Anything under the internals directory should not be explicitly exported and should not be considered stable (ie, require externally at your own risk as breaking changes inside internals will not be considered breaking for the lib).

@koulmomo koulmomo self-assigned this Mar 3, 2015
@koulmomo koulmomo changed the title [breaking changes][refactor] modularize async utils [refactor] modularize async utils Mar 3, 2015
@koulmomo koulmomo changed the title [refactor] modularize async utils modularize async utils Mar 3, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bd27d82 on refactor/modularize-async-methods into 3d2f6f0 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bd27d82 on refactor/modularize-async-methods into 3d2f6f0 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 271ab55 on refactor/modularize-async-methods into 3d2f6f0 on master.

@akshayp
Copy link
Contributor

akshayp commented Mar 3, 2015

This looks good to me @koulmomo 👍 💯

@akshayp
Copy link
Contributor

akshayp commented Mar 3, 2015

Also I don't see why this can't lead to a 1.0 bump

koulmomo added a commit that referenced this pull request Mar 3, 2015
@koulmomo koulmomo merged commit 7c5e2ca into master Mar 3, 2015
@koulmomo koulmomo deleted the refactor/modularize-async-methods branch March 3, 2015 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants