supporting windows attempt

[dreuxl]

trying to address #13

using this pkg https://www.npmjs.com/package/cross-spawn which seems to solve windows support.

I m a bit blind in that one, as I have no windows machine to test it 🤞

[FrederikCampagne]

I tried using crossSpawn. Just a note ---> crossSpawn returns a ChildProcess, so I believe you can leave you the child in child.crossSpawn(command, args). I'm running into other issues though. The retries actually start to run now, however they never exit the test run. I don't know how this can help as you don't have a windows machine to test it on. I will give it another go.

[stemkar123]

Hi,
I was facing same issue "Exit with Error code 199". And I have installed the crossSpawn as well & done the required changes in json file & retry file. Now I am getting below error:

[17:39:46] E/launcher - Error: TypeError: value.apply is not a function
at Promise.apply (D:\Reposirtory\test\ui\node_modules\q\q.js:1185:26)
at Promise.promise.promiseDispatch (D:\Reposirtory\test\ui\node_modules\q\q.js:808:41)
at D:\Reposirtory\test\ui\node_modules\q\q.js:1411:14
at runSingle (D:\Reposirtory\test\ui\node_modules\q\q.js:137:13)
at flush (D:\Reposirtory\test\ui\node_modules\q\q.js:125:13)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
[17:39:46] E/launcher - Process exited with error code 1

[schwepmo]

Hey,
is there any progress being made for implementing windows support?

[samuelvinay91]

When can we get Windows support please

[samuelvinay91]

@dreuxl we are really waiting for your fix for windows.Is there any ETA for this

[dreuxl]

No ETA at the moment :(

[samuelvinay91]

My current project is dependent on this module very badly..If I could help you in any way getting this I am happy to help @dreuxl

[tbowmo]

Tried patching with (almost) the proposed in this PR, and I got it to retry 3 times on windows, before finally bailing out with a failure..

System info:
Node : 8.12.0
npm: 6.4.1
yarn: 1.3.2
crossSpawn : 6.0.5

Only change made differently, than done in this PR is that I changed line 148 here to

            var child = crossSpawn(command,args);

[dreuxl]

I ll try that change and see.
Thanks @tbowmo

[samuelvinay91]

@tbowmo @dreuxl - I have retried the change given with my tests in windows .I could see that the retry is running ,but all the tests which include passed tests are also running again in next attempt

-----Dashboard spec.js------------
it('should able to Delete Dashboard', function () {
commonlib.DeleteDashboard('Automated'); ------------------this will run again even if it is passed at
first attempt
});
it('should able to Create a Dashlet of Chart type Area', function () {
commonlib.WaitForPageLoad();
//Refer the PO for complete Objects
commonlib.CreateDashlet('Finance Reports', 'Accts. Payable- Unpaid Bills', 'Basic Charts',
'Area', 'Bill Summary', 'Vendor Name', 'Sum', 'Bill Summary', 'Total Bill Amount');
});

[tbowmo]

@mechatrix

Did you turn on sharding? If not, then it runs all tests again.. (as per the readme file)

[tbowmo]

@dreuxl

Also note that I used version 6.0.5 of cross-spawn, and not 5.0.0, as you tried in the original attempt

[samuelvinay91]

@mechatrix

Did you turn on sharding? If not, then it runs all tests again.. (as per the readme file)

Yeah.You mean this shardTestFiles: true property right??

[tbowmo]

yup, that's the one.. and bump the "maxInstances" up a bit

capabilities: {
        browserName: "chrome",
        shardTestFiles: true,
        maxInstances: 12,
     .....
}

[linhub15]

Running this gives me Error: TypeError: Cannot read property 'crossSpawn' of undefined

Should this be crossSpawn(command, args); instead of child.crossSpawn(command, args)

[Enigmaderockz]

@mechatrix
Did you turn on sharding? If not, then it runs all tests again.. (as per the readme file)

Yeah.You mean this shardTestFiles: true property right??

Did it fix the issue? I am still facing the issue with running all the test cases again

[dreuxl]

closed in favor of #84