Avoid killing oneself if redis gets stuck dieing #194
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
When running redislite under GitHub Actions in an container (rather than directly on the runner) I see pytest die with exit code 137.
After some debugging I realised it's as GHA runs containers with
tail
as PID=1 which doesn't process signals correctly, so the daemonized redis-server goes<defunct>
aka Zombie when it exits. This sends redislite through a series of timeouts resulting in a final SIGTERM usingself.pid
which while non-zero at the start becomes zero by the time of the SIGTERM (I assume via some callback action inside the redis library this package extends), leading to a suicide. Switching to useprocess.pid
seems better for this situation & avoids the self-kill.