Add missing -Infinity support

yahoo · Feb 12, 2020 · 4599ec6 · 4599ec6
1 parent 18e2c56
commit 4599ec6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -103,7 +103,7 @@ module.exports = function serialize(obj, options) {
             return '@__U-' + UID + '-' + (undefs.push(origValue) - 1) + '__@';
         }
 
-        if (origValue === Infinity) {
+        if (type === 'number' && !isNaN(origValue) && !isFinite(origValue)) {
             return '@__I-' + UID + '-' + (infinities.push(origValue) - 1) + '__@';
         }
 
@@ -209,7 +209,7 @@ module.exports = function serialize(obj, options) {
         }
 
         if (type === 'I') {
-            return 'Infinity';
+            return infinities[valueIndex];
         }
 
         var fn = functions[valueIndex];

diff --git a/test/unit/serialize.js b/test/unit/serialize.js
@@ -388,6 +388,16 @@ describe('serialize( obj )', function () {
             var d = eval(serialize(Infinity));
             expect(d).to.equal(Infinity);
         });
+
+        it('should serialize -Infinity', function () {
+            expect(serialize(-Infinity)).to.equal('-Infinity');
+            expect(serialize({t: [-Infinity]})).to.be.a('string').equal('{"t":[-Infinity]}');
+        });
+
+        it('should deserialize -Infinity', function () {
+            var d = eval(serialize(-Infinity));
+            expect(d).to.equal(-Infinity);
+        });
     });
 
     describe('XSS', function () {