Fix suggestions when using select all #1422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tab into the input, select all and start to write something, no suggestion shows up
Massi-X
commented
Dec 3, 2024
| break; | ||
|
|
||
| // remove tag if has focus | ||
| case 'Backspace': { |
There was a problem hiding this comment.
Moved here because it needs to continue into default (to call on Input if relevant)
|
Hi, I've carefully investigated this bug and had made a fix which is very different than yours. |
|
No problem, you're great thanks! |
|
@Massi-X - How do you keep your Tagify package updated (NPM) if you are manually patching it? |
|
It's embedded, I'm not using NPM! |
|
OK but still, how to you manage to merge the my updates with your changes... it seems like a very delicate work which can get frustrating |
|
Yep indeed I'm waiting for all the fixes to be implemented 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yairEO this should be my last PR, take your time to review and/or improve them and ask me if you need any clarifications!
To trigger this bug (mode is select with whitelist):
I think this happens because the focus is not on the input but rather on the
tagTextelement, fixed the behavior by adding another case toonWindowKeyDownhandler that calls theonInputhandler.1.mov