Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty string for null request keyword #2700

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

sebdesign
Copy link

When the keyword from the request input is null, the keyword method returns null instead of a string as the phpdoc suggests.
This causes a TypeError when implementing custom filtering logic which expects a string for the keyword.

@yajra yajra merged commit a497567 into yajra:9.0 Oct 27, 2021
@yajra
Copy link
Owner

yajra commented Oct 27, 2021

Released on v9.18.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants