Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added null parameter type as allowed to handle default Action column from laravel-datatables-html #2787

Conversation

adamale
Copy link
Contributor

@adamale adamale commented May 17, 2022

No description provided.

@adamale
Copy link
Contributor Author

adamale commented May 17, 2022

While upgrading laravel-datatables packages to the latest version I've encountered crashing caused by the Action column's render parameter being set to null initially (as defined in laravel-datatables-html). The isJavascript() method does not accept null values so this PR aims to fix that.

Right now I'm handling that by overriding default render param with the following function: fn() => false, but I'd definitely prefer the laravel-datatables to take care of that.

@yajra yajra merged commit fa35dc0 into yajra:master May 18, 2022
@yajra
Copy link
Owner

yajra commented May 18, 2022

Released on v10.0.6 🚀 Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants