New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: case insensitive starts with search #2917 #2916

Merged

yajra merged 1 commit into yajra:master from uchajk:master

Dec 6, 2022

Contributor

uchajk commented Dec 6, 2022

'search'         => [
        'smart'            => false,
        'multi_term'       => false,
        'case_insensitive' => true,
        'use_wildcards'    => false,
        'starts_with'      => true,
    ],

If this is the case, line 449 would return keyword% without converting it to lower case first. The change suggested in this request will first check the sensitivity, convert to lower if set to true, and then return lower("$keyword%").


          return after inspecting case insensitivity

608e83c

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

yajra changed the title ~~return after inspecting case insensitivity~~ fix: case insensitive starts with search #2917

yajra merged commit 68fb2a6 into yajra:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet