Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix anonymous resource collection data formatting #2944

Merged

Conversation

hpacleb
Copy link
Collaborator

@hpacleb hpacleb commented Feb 4, 2023

Fixes #2943
Issue seems to be due to an extra layer of properties when converting a resource to a collection.

Normal Collection :
image

Converted Resource Collection :
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yajra
Copy link
Owner

yajra commented Feb 19, 2023

@pinmosarn requesting review, thanks!

@yajra yajra merged commit 16d6a97 into yajra:master Feb 20, 2023
yajra added a commit to yajra/laravel-datatables-buttons that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTables warning: table id=datatable - Requested unknown parameter 'id' for row 0, column 0.
2 participants