feat: Optimize countQuery with complex select

[Arkhas]

When performing subqueries, some of the keywords used to determine if a query is complexe can be found in subqueries inside the main query :

protected function isComplexQuery($query): bool
{
     return Str::contains(Str::lower($query->toSql()), ['union', 'having', 'distinct', 'order by', 'group by']);
}

For exemple :

select 
    "users".*,
    (select id from posts where posts.user_id = users.id order by created_at desc limit 1) as last_post_id
from "users"

This query was detected as complexe, but the subquery had no impact on the number of records returns,
The subquery was executed and had a huge impact on performance

To force this behavior, you can use the ignoreSelectsInCountQuery() on a QueryDatatable :

 $dataTable = app('datatables')->of(
            DB::table('users')
                ->select('users.*')
                ->addSelect([
                    'last_post_id' => DB::table('posts')
                                        ->whereColumn('posts.user_id', 'users.id')
                                        ->orderBy('created_at')
                                        ->select('id'),
                ])
                ->orderBy(DB::table('posts')->whereColumn('posts.user_id', 'users.id')->orderBy('created_at')->select('created_at')
                )
        )->ignoreSelectsInCountQuery();

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[Arkhas]

ping @yajra

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[Arkhas]

I am struggling every time with the CI, does StyleCI have an automated fixer ? It would be much easier :)

[yajra]

I am struggling every time with the CI, does StyleCI have an automated fixer ? It would be much easier :)

No problem with StyleCI, I can automate the PR afterwards.

[yajra]

There is still a Static Analysis issue:

 ------ --------------------------------------------- 
  Line   QueryDataTable.php                           
 ------ --------------------------------------------- 
  168    Negated boolean expression is always false.  
 ------ --------------------------------------------- 

But let me check again further. If it's a false positive, maybe we can just add it to ignored errors?

[Arkhas]

yeah I don't understand why it is detected like that

[Arkhas]

where you able to check it ? Or do you need more explanation on what the function does ?

[yajra]

Released on v10.4.4 🚀 including the fixes for phpstan. Thanks!