Enhance pagination as suggested on #563.

yajra · Dec 6, 2020 · 326175e · 326175e
1 parent d0f63b8
commit 326175e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Oci8/Query/Grammars/OracleGrammar.php b/src/Oci8/Query/Grammars/OracleGrammar.php
@@ -161,6 +161,12 @@ protected function compileTableExpression($sql, $constraint, $query)
             return "select * from ({$sql}) where rownum {$constraint}";
         }
 
+        if (! is_null($query->limit && ! is_null($query->offset))) {
+            $start  = $query->offset + 1;
+            $finish = $query->offset + $query->limit;
+            return "select t2.* from ( select rownum AS \"rn\", t1.* from ({$sql}) t1 where rownum <= {$finish}) t2 where t2.\"rn\" >= {$start}";
+        }
+
         return "select t2.* from ( select rownum AS \"rn\", t1.* from ({$sql}) t1 ) t2 where t2.\"rn\" {$constraint}";
     }