fix: missing prefix on table alias #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2024 11:35
Updated the OracleGrammar to correctly prefix both segments of table names when wrapping them. This ensures that any table name with multiple segments is correctly processed for Oracle queries.
Updated the tests to correctly reflect alias prefixing for table names with setTablePrefix. This ensures that aliases are consistently prefixed in the generated SQL statements.
yajra
approved these changes
Sep 7, 2024
yajra
changed the title
|
Released on https://github.com/yajra/laravel-oci8/releases/tag/v11.6.1 🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Updated the OracleGrammar to correctly prefix both segments of table names when wrapping them.
This pr resolve #886 and i think resolve #875 too