forked from rails/rails
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ActiveRecord::Relation unions [PROPOSAL], closes rails#939
Depends on rails/arel#118. The accepted implementation could act as a unions list, or a new top-level object, which would change this patch proposal.
- Loading branch information
Olivier Favre
committed
Aug 3, 2012
1 parent
01b470f
commit 29b8ebd
Showing
1 changed file
with
18 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29b8ebd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Olivier
Is anything happening to these code changes?
Are you going to pull request this?
Regards,
Andrew
29b8ebd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rails/arel#118 needs to be merged first.
As @jroes just decided to let me drive it, I'll compare my solution to his and come up with a workable pull request.
Once merged, I could then adapt this patch and pull request it.
I'll commit my proposal "as is" (NoWarranty™) so you can build upon it, or drive these issues as I'm not sure of the time I can put on these.