fix: display of square badge with small content size #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add triangle badge shape * Add widget tests for triangle badge shape
* Update custom painter for all custom shapes to set fixed-size proportions * Return default value of child content for verified account widgets * Resize the shape depending on the child widget in the same proportions * Fix git check errors * Resize all types of shapes depending on the size child widget * Add method for calculate default badge content padding value * Change method for calculate default badge content padding value * Add unit tests for calculateBadgeContentPadding method
|
it worked,so i'll close this issues ,but i found if you chang '123' to '1' ,it able to recurrent(just in hot reload,when you restart it's ok),i don't know why..... |
|
@86linksrain I fixed this problem can you check with the new changes now? |
|
👍🏻👍🏻👍🏻👍🏻 perfect |
… shapes, also update unit tests
# Conflicts: # CHANGELOG.md # README.md # example/.flutter-plugins-dependencies # pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #110
Change the display of the badge with the content of small size, without changing all the functions while maintaining the proportions
Screenshots or Videos
Badge before changes :
Badge after changes :
