Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linker options for Xen/Mini-OS #231

Merged
merged 2 commits into from
Dec 18, 2014
Merged

Add linker options for Xen/Mini-OS #231

merged 2 commits into from
Dec 18, 2014

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Dec 16, 2014

Note: depends on mirage/mirage-platform#111

@yallop
Copy link
Owner

yallop commented Dec 16, 2014

Thanks!

Is there an easy way to set up CI for ctypes on Xen/Mini-OS? It'd be useful to have some kind of automatic check to avoid inadvertently breaking the build.

@talex5 talex5 force-pushed the minios branch 4 times, most recently from 7d0cbf2 to c78c3ec Compare December 17, 2014 10:17
@talex5
Copy link
Contributor Author

talex5 commented Dec 17, 2014

I've added some tests. Note however that they won't pass until the next mirage-platform release.

@avsm
Copy link
Contributor

avsm commented Dec 17, 2014

mirage-platform releases with this change now in ocaml/opam-repository#3219

@yallop
Copy link
Owner

yallop commented Dec 17, 2014

The tests are passing on linux/4.01.0 now, but failing on osx (as expected, presumably).

@talex5
Copy link
Contributor Author

talex5 commented Dec 17, 2014

I would have thought you should be able to install mirage-xen on OS X, but I don't have a machine to test it.

@avsm
Copy link
Contributor

avsm commented Dec 17, 2014

mirage-xen wont compile on osx just yet due to the mirage-xen-minios dep

@talex5 talex5 force-pushed the minios branch 2 times, most recently from ca85276 to 606cb4e Compare December 18, 2014 10:24
@talex5
Copy link
Contributor Author

talex5 commented Dec 18, 2014

I've updated the tests to check the Xen support only when mirage-xen is installable. This means that when more platforms are supported, the tests should run there too.

@yallop
Copy link
Owner

yallop commented Dec 18, 2014

Thanks, @talex5!

yallop added a commit that referenced this pull request Dec 18, 2014
Add linker options for Xen/Mini-OS
@yallop yallop merged commit 07c2ad5 into yallop:master Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants