various windows fixes #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__USE_MINGW_ANSI_STDIO` must be defined before any other relevant
headers are included. This is often not guaranteed because custom
headers are added before calls to `Cstubs.write_c`. A
macro ('ctypes_printf') is introduced instead.
Background: On windows one can link again various version of the
cstlib (crt). They are all not really compatible to C99. Instead of
testing workarounds for each version, the compatibility layer of mingw
is used.
workarounds for - ocaml/ocaml#1535 (no dll dependency) - ocaml/ocaml#1528 (string_of_float format) - ocaml/ocaml#1479 (chdir changes environment)
|
Thank you! |
yallop
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove
__USE_MINGW_ANSI_STDIOfrom the stub generation code.__USE_MINGW_ANSI_STDIOmust be defined before any other relevant headers are included. This is often not guaranteed because custom headers are added before calls toCstubs.write_c. I've instead added thectypes_printfmacro for usage inside generated code, which translates to__mingw_printffor mingw, andprintfotherwise. (Background: On windows one can link again various version of the c stdlib (crt). They are all not really compatible to C99. Instead of adding and testing workarounds for each version, the compatibility layer of mingw is used. This layer is normally enabled by defining__USE_MINGW_ANSI_STDIOor by certain compiler switches.)The second commit removes a dll dependency introduced by OCaml 4.07 and adds further workarounds to the test suite.