Reflect "managed" status in the types of fat pointers #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Obj.t Expose whether the managed object is optional in the type, and make it mutable.
fdopen
added a commit
to fdopen/ppx_cstubs
that referenced
this pull request
Jan 22, 2020
Cstubs_internals.cptr and Cstubs_internals.fptr were removed in yallop/ocaml-ctypes#619
fdopen
added a commit
to fdopen/ppx_cstubs
that referenced
this pull request
Jan 22, 2020
Cstubs_internals.cptr and Cstubs_internals.fptr were removed in yallop/ocaml-ctypes#619
fdopen
added a commit
to fdopen/ppx_cstubs
that referenced
this pull request
Jan 24, 2020
Cstubs_internals.cptr and Cstubs_internals.fptr were removed in yallop/ocaml-ctypes#619
fdopen
added a commit
to fdopen/ppx_cstubs
that referenced
this pull request
Jan 24, 2020
Cstubs_internals.cptr and Cstubs_internals.fptr were removed in yallop/ocaml-ctypes#619
fdopen
added a commit
to fdopen/ppx_cstubs
that referenced
this pull request
Jan 26, 2020
Cstubs_internals.cptr and Cstubs_internals.fptr were removed in yallop/ocaml-ctypes#619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This internal-only change eliminates the use of
Obj.tinCtypes_ptr.Fat.t, instead reflecting the type of themanagedfield in the type and using existential types in clients (such asCtypes.pointerandCtypes.static_funptr) to hide the additional type parameter.This change should eventually make it possible to give a more compact representation to
Foreign.dynamic_funptr(#595).