Merge pull request #68 from yamadashy/fix/windows-default-ignore

Fix default ignore patterns for subdirectories
yamadashy · Sep 2, 2024 · d53b56e · d53b56e
2 parents d0ab56b + 2a000fa
commit d53b56e
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 8 deletions.
diff --git a/src/config/defaultIgnore.ts b/src/config/defaultIgnore.ts
@@ -7,7 +7,15 @@ export const defaultIgnoreList = [
 
   // Dependency directories
   'node_modules/**',
+  '**/node_modules/**',
   'bower_components/**',
+  '**/bower_components/**',
+  'jspm_packages/**',
+  '**/jspm_packages/**',
+  'vendor/**',
+  '.bundle/**',
+  '.gradle/**',
+  'target/**',
 
   // Logs
   'logs/**',
@@ -34,18 +42,12 @@ export const defaultIgnoreList = [
   // Grunt intermediate storage
   '.grunt/**',
 
-  // Bower dependency directory
-  'bower_components/**',
-
   // node-waf configuration
   '.lock-wscript',
 
   // Compiled binary addons
   'build/Release/**',
 
-  // Dependency directories
-  'jspm_packages/**',
-
   // TypeScript v1 declaration files
   'typings/**',
 

diff --git a/tests/core/file/fileSearcher.test.ts b/tests/core/file/fileSearcher.test.ts
@@ -61,7 +61,7 @@ describe('fileSearcher', () => {
       const patterns = await getIgnorePatterns(process.cwd(), mockConfig);
 
       expect(patterns.length).toBeGreaterThan(0);
-      expect(patterns).toContain('node_modules/**');
+      expect(patterns).toContain('**/node_modules/**');
     });
 
     test('should include custom patterns', async () => {
@@ -89,7 +89,7 @@ describe('fileSearcher', () => {
 
       const patterns = await getIgnorePatterns(process.cwd(), mockConfig);
 
-      expect(patterns).toContain('node_modules/**');
+      expect(patterns).toContain('**/node_modules/**');
       expect(patterns).toContain('*.custom');
       expect(patterns).toContain('temp/');
     });

diff --git a/tests/integration-tests/fixtures/packager/inputs/simple-project/.repopackignore b/tests/integration-tests/fixtures/packager/inputs/simple-project/.repopackignore
@@ -0,0 +1 @@
+**/build/**
diff --git a/tests/integration-tests/fixtures/packager/inputs/simple-project/build/test.js b/tests/integration-tests/fixtures/packager/inputs/simple-project/build/test.js
@@ -0,0 +1 @@
+// this file should be ignored
diff --git a/tests/integration-tests/fixtures/packager/inputs/simple-project/src/build/test.js b/tests/integration-tests/fixtures/packager/inputs/simple-project/src/build/test.js
@@ -0,0 +1 @@
+// this file should be ignored
diff --git a/tests/integration-tests/fixtures/packager/outputs/simple-project-output.txt b/tests/integration-tests/fixtures/packager/outputs/simple-project-output.txt
@@ -56,6 +56,7 @@ resources/
 src/
   index.js
   utils.js
+.repopackignore
 package.json
 README.md
 repopack.config.json
@@ -96,6 +97,11 @@ module.exports = {
   greet,
 };
 
+================
+File: .repopackignore
+================
+**/build/**
+
 ================
 File: package.json
 ================

diff --git a/tests/integration-tests/fixtures/packager/outputs/simple-project-output.xml b/tests/integration-tests/fixtures/packager/outputs/simple-project-output.xml
@@ -53,6 +53,7 @@ resources/
 src/
   index.js
   utils.js
+.repopackignore
 package.json
 README.md
 repopack.config.json
@@ -88,6 +89,10 @@ module.exports = {
 };
 </file>
 
+<file path=".repopackignore">
+**/build/**
+</file>
+
 <file path="package.json">
 {
   "name": "simple-project",