fix(compress): Fix partial exclusion of TypeScript imports

[yamadashy]

Checklist

• Run npm run test
• Run npm run lint

PR Overview

This PR updates test coverage and refactors dependency injection for file processing while making some minor adjustments to queries and documentation.

• Adds tests for the new initPiscina functionality in processConcurrency.
• Refactors fileProcess tests to use a mocked file manipulator via dependency injection.
• Updates the FileManipulator interface export, tree-sitter query naming, and documentation folder naming.

Reviewed Changes

File	Description
tests/shared/processConcurrency.test.ts	Added tests for initPiscina and updated mocking for Piscina.
tests/core/file/fileProcess.test.ts	Replaced direct getFileManipulator mocks with dependency injection via a custom mock.
src/core/treeSitter/queries/queryTypescript.ts	Added an extra query for named imports in TypeScript files.
src/core/file/fileManipulate.ts	Changed FileManipulator to an exported interface to allow reuse.
src/core/file/fileProcess.ts	Updated dependency injection to include getFileManipulator with relevant type definitions.
.github/copilot-instructions.md	Renamed folder reference from tree-sitter to treeSitter for consistency.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

[cloudflare-workers-and-pages]

Deploying repomix with    Cloudflare Pages

Latest commit:	3f8dff6
Status:	✅  Deploy successful!
Preview URL:	https://b5a9cdc9.repomix.pages.dev
Branch Preview URL:	https://chore-test-coverage.repomix.pages.dev

View logs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (706fe8f) to head (3f8dff6).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   89.70%   90.17%   +0.46%     
==========================================
  Files          72       72              
  Lines        3468     3470       +2     
  Branches      747      750       +3     
==========================================
+ Hits         3111     3129      +18     
+ Misses        357      341      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request makes several enhancements and refactorings across the repository. The changes include a renaming of a directory from tree-sitter/ to treeSitter/ to align with updated naming conventions. The FileManipulator interface in fileManipulate.ts has been updated from private to exported, allowing broader access. A new type alias, GetFileManipulator, has been introduced in fileProcess.ts, and the dependency injection in the processFiles function is refined to explicitly include initTaskRunner and getFileManipulator. Additionally, the TypeScript query in the Tree-sitter query file now supports an extended pattern for parsing more complex import statements. Test modifications include simplifying the mocking mechanism for file manipulation and adding a dedicated test suite to validate the initialization behavior of initPiscina in the concurrency module.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant PF as processFiles
    participant ITR as initTaskRunner
    participant GFM as getFileManipulator
    participant FM as FileManipulator

    C->>PF: Call processFiles(filePath, deps)
    PF->>ITR: Initialize task runner
    PF->>GFM: Get FileManipulator instance for filePath
    alt FileManipulator exists
        GFM-->>PF: Return FileManipulator instance
        PF->>FM: Use methods (removeComments, removeEmptyLines)
    else FileManipulator is null
        GFM-->>PF: Return null
    end
    PF-->>C: Return processed content

Loading

sequenceDiagram
    participant T as Test Suite
    participant IP as initPiscina
    participant P as Piscina

    T->>IP: Call initPiscina()
    IP->>P: Instantiate Piscina with configuration
    P-->>IP: Return Piscina instance
    IP-->>T: Provide configured Piscina object

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 706fe8f and 3f8dff6.

📒 Files selected for processing (6)

• .github/copilot-instructions.md (1 hunks)
• src/core/file/fileManipulate.ts (1 hunks)
• src/core/file/fileProcess.ts (2 hunks)
• src/core/treeSitter/queries/queryTypescript.ts (1 hunks)
• tests/core/file/fileProcess.test.ts (2 hunks)
• tests/shared/processConcurrency.test.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• .github/copilot-instructions.md

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Test (windows-latest, 23.x)
• GitHub Check: Test (windows-latest, 22.x)
• GitHub Check: Test (windows-latest, 21.x)
• GitHub Check: Test (windows-latest, 19.x)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Cloudflare Pages

🔇 Additional comments (13)

src/core/file/fileManipulate.ts (1)

4-4: Good change - exposing the FileManipulator interface

Making the FileManipulator interface public is a positive improvement that enables better modularity and testability by allowing direct implementation in tests and usage in other modules.

src/core/treeSitter/queries/queryTypescript.ts (1)

5-9: Enhanced import statement detection - good addition

The new pattern extends the query to detect more complex TypeScript import statements with named imports, which improves the parsing capabilities without breaking existing functionality.

tests/shared/processConcurrency.test.ts (4)

2-2: Added Piscina mock import

Good addition for the new test case that verifies Piscina initialization.

---

4-4: Updated import to include initPiscina

Adding initPiscina to the imports enables testing this function, improving test coverage.

---

7-7: Added mock for Piscina

Good practice to mock external dependencies for more controlled unit testing.

---

63-81: Comprehensive test for initPiscina function

The new test suite effectively validates that initPiscina correctly initializes a Piscina instance with the expected configuration parameters. This improves test coverage for concurrency-related functionality.

The test properly verifies:

1. Correct parameter passing to Piscina constructor
2. Proper thread count settings
3. Idle timeout configuration

src/core/file/fileProcess.ts (3)

6-6: Updated import to use the exported FileManipulator type

Good update to utilize the newly exported interface, improving code organization.

---

10-10: Added GetFileManipulator type alias

This type alias improves code readability and type safety by clearly defining the function signature for file manipulator retrieval.

---

21-27: Enhanced dependency injection with explicit typing

The updated deps parameter now has explicit types for both initTaskRunner and getFileManipulator, which improves type safety and makes the dependency injection pattern more clear.

This change:

1. Makes dependencies more explicit
2. Improves maintainability
3. Enhances testability by clearly defining what can be injected

tests/core/file/fileProcess.test.ts (4)

2-2: Good job importing the type instead of the actual implementation.

Using explicit type imports is a clean approach that avoids importing unnecessary runtime code in test files.

---

9-12: Well-implemented mock that follows the interface contract.

This mock implementation of FileManipulator correctly implements the interface with simple yet effective regex patterns for both required methods.

---

14-19: Good approach to conditional mock creation.

The function correctly returns a mock manipulator only for JavaScript files, which mimics the actual behavior while keeping the tests isolated from implementation details.

---

43-43: Improved test isolation with dependency injection.

Using direct dependency injection of the mock instead of vi.mocked is a better approach that:

1. Makes the tests more resilient to implementation changes
2. Provides clearer intent in the test code
3. Follows the explicit dependencies principle

This refactoring improves maintainability of the test suite.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.