Accept viewport size as an argument for a proper screenshot of the large pivot table #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doiken
commented
Oct 21, 2024
| @@ -28,7 +47,8 @@ export const handleRecordChart: Handler = ({ redash, browser }) => { | |||
| const embedUrl = `${redash.alias}/embed/query/${queryId}/visualization/${visualizationId}?api_key=${redash.apiKey}` | |||
| const filename = `${query.name}-${visualization?.name}-query-${queryId}-visualization-${visualizationId}.png` | |||
|
|
|||
| const file = await browser.capture(embedUrl) | |||
| const options = prepareOptions(context.matches.input) | |||
There was a problem hiding this comment.
There are several candidate methods for obtaining input values.
The motivation for retrieving from matches.input is to also cover workflow steps, slash command
|
Great idea, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Screenshots of large pivot tables, such as those using scrollbars, show a broken table.
So it's nice to have the ability to specify the size of the viewport.
Changes:
Testing:
Execute the query at the beginning with arguments.