Add specific files back to .gitignore #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingydotnet
reviewed
Apr 19, 2020
perlpunk
force-pushed
the
perlpunk/gitignore
branch
from
34f4c45 to
e555c4c
Compare
done |
ingydotnet
reviewed
Apr 20, 2020
There was a problem hiding this comment.
@perlpunk Thanks. I was thinking that you could take this opportunity to add the / to all the entries where they belong, not just the new ones.
I can do it if you don't want to. Let me know.
perlpunk
force-pushed
the
perlpunk/gitignore
branch
from
e555c4c to
b39ca83
Compare
|
I added a slash for those files where I'm sure they are in the root directory. |
perlpunk
force-pushed
the
perlpunk/gitignore
branch
from
b39ca83 to
33a9fd6
Compare
|
Added back |
ingydotnet
approved these changes
Apr 20, 2020
Seems this was an oversight in d050fe3. We don't want to ignore all those file, but only the compiled executables. Also added '/' to several files.
perlpunk
force-pushed
the
perlpunk/gitignore
branch
from
33a9fd6 to
ce83579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #118
Seems this was an oversight in d050fe3.
We don't want to ignore all those file, but only the compiled executables.