Add -h and --flow (on|off|keep) to run-*-test-suite #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
perlpunk/keepflow
branch
from
7d21819 to
8f3dffb
Compare
perlpunk
force-pushed
the
perlpunk/keepflow
branch
from
8f3dffb to
149d738
Compare
perlpunk
changed the title
ingydotnet
approved these changes
May 31, 2020
perlpunk
force-pushed
the
perlpunk/keepflow
branch
from
149d738 to
22ec689
Compare
With `--flow (keep|on)` run-parser-test-suite will output:
+MAP {}
+SEQ []
run-emitter-test-suite will then emit flow style collections if requested:
echo 'foo: [bar, {x: y}]' | ./tests/run-parser-test-suite | ./tests/run-emitter-test-suite
echo 'foo: [bar, {x: y}]' | ./tests/run-parser-test-suite \
--flow keep | ./tests/run-emitter-test-suite --flow keep
Also: add that yaml_private.h include again that I had thrown out. Needed
for printing directives.
Wonder if there is a way to create a directive without using the private api.
perlpunk
force-pushed
the
perlpunk/keepflow
branch
from
e3da7da to
15fe0fb
Compare
ingydotnet
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the yaml-test-suite will soon add the
[]and{}flow collection styles to the event output, we need to be able to deal with both formats. This way, when switching to the new format, we just need to add the--flowparameter to the call.This also makes it easier to test my recent fixes in flow style mode.
With
--flow (keep|on)run-parser-test-suite will output:run-emitter-test-suite will then emit flow style collections if requested: