Fix bug affecting sqlite3 date fields: Date columns are now converted to YYYY-MM-DD format #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which means they will be imported correctly into sqlite3 databases.
brianmeidell
changed the title
added 2 commits
May 10, 2015 20:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping from MySQL and loading to sqlite3 was failing for me.
Sqlite3 doesn't have native date formats (afaik), so rails deals with that by storing dates as iso8601 (YYYY-MM-DD HH:MM:SS etc) in sqlite3.
It turns out it was because dates would get dumped from mysql to the yaml file in a format like "Mar 23, 2015", which then got imported straight into sqlite as a string. This made a lot of rails date handling silently and subtly fail, because rails seems to rely on lexical ordering of date fields to work.
This commit fixes that problem, by adding the same type of conversion as happens for booleans - it takes all the date fields and converts them to YYYY-MM-DD. Datetime seemed unaffected by this problem, so I only deal with date.
I haven't checked it extensively for side effects, but it passes the yaml_db unit tests, and I suspect this is a reasonably correct approach that should work with other dbs.