Add support for proper onprogress events for file uploads #20
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when sending formData, we need to attach the `onprogress` handler to `request.upload` instead of directly to `request`. This ensures that the `onprogress` handler receives events with `lengthComputable = true`
|
Could you add some documentation and tests? I'd like to run it through a multi-platform test suite. |
|
Think these should do the trick 😄 On a side note, Zuul seems a bit temperamental. It keeps failing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when sending formData, we need to attach the
onprogresshandler torequest.uploadinstead of directly to
request.This ensures that the
onprogresshandler receives events withlengthComputable = true