Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 0.1.3, cannot be used with yarn #55

Closed
hyperknot opened this issue Apr 1, 2022 · 8 comments
Closed

Regression in 0.1.3, cannot be used with yarn #55

hyperknot opened this issue Apr 1, 2022 · 8 comments

Comments

@hyperknot
Copy link

hyperknot commented Apr 1, 2022

Describe the bug

0.1.3 cannot be used with yarn. Running yarn five-server does the following on macOS:

env: node\r: No such file or directory

0.1.2 works perfectly.

The reason I believe is some Windows line ending CRLF might have sneaked in either in Git source or in the npm generation.
Running dos2unix on the file fixes it.

yandeu added a commit that referenced this issue Apr 1, 2022
@yandeu
Copy link
Owner

yandeu commented Apr 1, 2022

I don't know. Could it be a yarn issue? npx five-server@0.1.3 . seems to work.

@hyperknot
Copy link
Author

Based on the article, npx silently changes things to the right ending. yarn doesn't.

@yandeu
Copy link
Owner

yandeu commented Apr 1, 2022

So everything should be lf?

@hyperknot
Copy link
Author

Yes, I believe that's it. Your prettier changes might be all that's needed.

yandeu added a commit that referenced this issue Apr 1, 2022
@yandeu
Copy link
Owner

yandeu commented Apr 1, 2022

I found this microsoft/TypeScript#29928

@yandeu
Copy link
Owner

yandeu commented Apr 1, 2022

Can you please try v0.1.4?

@hyperknot
Copy link
Author

0.1.4 works perfectly, thanks for the quick fix!

@yandeu
Copy link
Owner

yandeu commented Apr 1, 2022

You're welcome 😁

@yandeu yandeu closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants