Selenium3 5 integration #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
reviewed
Aug 19, 2017
| @@ -24,7 +26,7 @@ public By buildBy() { | |||
| Class<?> clazz = elementClass; | |||
| while (clazz != Object.class) { | |||
| if (clazz.isAnnotationPresent(FindBy.class)) { | |||
| return buildByFromFindBy(clazz.getAnnotation(FindBy.class)); | |||
| return new FindByBuilder().buildIt(clazz.getAnnotation(FindBy.class), null); | |||
There was a problem hiding this comment.
why it moved so far to the right?
There was a problem hiding this comment.
That was due to I used tabs for indentation. Fixed
|
👍 Thanks for the fix! Can u shift return statements a little bit left (to align with other code)? I will merge and release it then. |
eroshenkoam
pushed a commit
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #139