Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image element #57

Merged
merged 3 commits into from
Apr 24, 2014
Merged

Image element #57

merged 3 commits into from
Apr 24, 2014

Conversation

proxeter
Copy link
Contributor

No description provided.

@aik099
Copy link
Contributor

aik099 commented Apr 20, 2014

Can you please provide any potential usages for this element? Preferably with some example pages.

@artkoshelev
Copy link
Contributor

Can you please add some unit-tests as well?

@proxeter
Copy link
Contributor Author

aik099, sure. We have spinner (loading element, ) on page. Actually we have 3 different spinner with different sizes and src paths. Need to check that they exists on page and not visible before they won't be caused. I can use WebElement, but TypifiedElement preferred.

artkoshelev, yes. Tomorrow i'll do this

@aik099
Copy link
Contributor

aik099 commented Apr 20, 2014

Need to check that they exists on page and not visible before they won't be caused.

Then you can add isVisible method as well. I don't remember if the TypifiedElement has it by default.

@proxeter
Copy link
Contributor Author

aik099, i think it's not nessecary. We have element (and his attributes) and can use matchers for manipulating.

@proxeter
Copy link
Contributor Author

@artkoshelev, tests done

artkoshelev added a commit that referenced this pull request Apr 24, 2014
@artkoshelev artkoshelev merged commit 90c295c into yandex-qatools:master Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants