Fix for issue #65 #66
Conversation
| // element must be <textarea> or <input> with type text, password, email etc | ||
| // See https://github.com/yandex-qatools/htmlelements/issues/65 | ||
| private static String getClearTextInputElementCharSequence(WebElement element) { | ||
| return StringUtils.repeat(Keys.DELETE.toString() + Keys.BACK_SPACE, element.getText().length()); |
There was a problem hiding this comment.
Why you call .toString() method?
I believe if we call it, then it needs to be done for BACK_SPACE key as well.
There was a problem hiding this comment.
It doesn't compile without .toString() beause Keys is an enum.
Keys.BACK_SPACE is implicitly converted to string.
http://stackoverflow.com/questions/328661/explicit-vs-implicit-call-of-tostring
There was a problem hiding this comment.
for some fields element.getText() will return empty string when element.getAttribute("value") will return not empty result
There was a problem hiding this comment.
In that case we need to replace element.getText().length() with Math.max(element.getText().length(), element.getAttribute("value")).
There was a problem hiding this comment.
Ah. I finally see, why there is a problem. In the original code, that was used to create that PR: https://github.com/minkphp/MinkSelenium2Driver/blob/master/src/Selenium2Driver.php#L659-L662 we're:
- operation only on
inputandtextareaelements - always taking the
valueattribute value (theattributemethod in selenium in fact looks in JS.valueproperty on DOM node and gets it's value, rather then HTML attributevalue, that doesn't exist on textarea)
And using getText here is a huge mistake, because https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/element/:id/text it returns visible text on element (e.g. div and such), but not inputs :)
|
Issue numbers mentioned in PR title doesn't auto-link PR with corresponding issue. Usually I put this into description: Related to #65 |
|
Will this pull request be merged? |
|
Looks good, can you add some tests to document new behavior? |
|
well done! |
|
Aren't there any universal method for getting element value? |
|
I thought |
| } | ||
| } | ||
|
|
||
| // Returns sequence of backspaces and deletes that will clear element |
There was a problem hiding this comment.
for future prs :) - use javadoc style comments on methods - \** */
Related to #65