Form.fill() doesn't clear text inputs before calling sendKeys()

[emaks]

    @Test
    public void test() {
        Map<String, Object> data = new HashMap<>();
        data.put("login", "email_login");

        MainPage page = new MainPage(new FirefoxDriver());

        page.open();
        page.fillLogin(data);
        Assert.assertEquals(data.get("login"), page.getLogin());
        page.fillLogin(data);
        Assert.assertEquals(data.get("login"), page.getLogin());
    }

    public class MainPage {
        @FindBy(css = "form[role=form]")
        private Form loginForm;

        WebDriver driver;

        public MainPage(WebDriver driver) {
            this.driver = driver;
            PageFactory.initElements(new ElementDecorator(this.driver), this);
        }

        public void open() {
            driver.get("http://www.yandex.ua/");
        }

        public void fillLogin(Map<String, Object> data) {
            loginForm.fill(data);
        }

        public String getLogin() {
            return loginForm.getWrappedElement().findElement(By.cssSelector("[name=login]")).getAttribute("value");
        }
    }

[artkoshelev]

test this please

[artkoshelev]

that's good, please squash this commits into one and we'll merge it

[aik099]

Looks like a code duplication. We have similar issue with other element in past and it was solved there. I think that we should be using corresponding element methods, e.g. TextElement to set their value instead of fallback to sendKeys and similar methods.

[emaks]

please squash this commits into one

done

[artkoshelev]

@emaks wouldn't this change brake filling TextArea elements?

[emaks]

@artkoshelev, please, see new implementation.
and I have one question: Why there are no exceptions in this cases: 1st, 2nd ?

[artkoshelev]

i think it's better to use StringUtils.defaultString which is null-safe version of String

[artkoshelev]

@emaks, and answering your question about exceptions, i don't know the reasons behind this implementation, but at least it works exactly as described in javadoc =)

[artkoshelev]

please change comment style to multiline here

[emaks]

done

[artkoshelev]

test this please

[emaks]

@artkoshelev Are there any additional problems with pull request?

[artkoshelev]

@emaks i just need some time to made a final review

[artkoshelev]

landed, thanks!