-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC zero left padding for PODArray #3920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added a commit
that referenced
this pull request
Dec 25, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 27, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 8, 2019
@amosbird What is 'hashfile' you referenced in your test? |
@alesapin It's a data file shared by @alexey-milovidov It has the following schema and I use it for hash testing
|
Selected columns from |
@alesapin If you substitute |
alexey-milovidov
added a commit
that referenced
this pull request
Mar 8, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Mar 8, 2019
…d-left-in-pod-array Fixed awful error after #3920
alexey-milovidov
added a commit
that referenced
this pull request
Mar 10, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Mar 11, 2019
Removed obsolete code after #3920
alexey-milovidov
added a commit
that referenced
this pull request
Mar 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Zero left padding PODArray so that -1 element is always valid and zeroed. It's used for branchless Offset access.
simple tests show 1%-5% improvements
Before padding
After padding