Fix restore of parametrized views

Makefile

@@ -52,7 +52,7 @@ build: install-deps ch_backup/version.txt
 all: build lint test-unit test-integration
 
 .PHONY: lint
-lint: install-deps isort black codespell ruff pylint mypy bandit
+lint: build isort black codespell ruff pylint mypy bandit
 
 .PHONY: isort
 isort: install-deps
@@ -75,7 +75,7 @@ ruff: install-deps
 	${TEST_ENV} ruff check $(SRC_DIR) $(TESTS_DIR)
 
 .PHONY: pylint
-pylint: install-deps
+pylint: build
 	${TEST_ENV} pylint $(SRC_DIR)
 	${TEST_ENV} pylint --disable=missing-docstring,invalid-name $(TESTS_DIR)
 

ch_backup/logging.py

@@ -113,7 +113,10 @@ def configure(config_loguru: dict) -> None:
             handler["filter"] = make_filter(name)
         loguru_handlers.append(handler)
 
-    logger.configure(handlers=loguru_handlers, activation=[("", True)])
+    logger.configure(
+        handlers=loguru_handlers,  # type: ignore
+        activation=[("", True)],
+    )
 
     # Configure logging.
     logging.basicConfig(handlers=[InterceptHandler()], level=0)

ch_backup/logic/table.py

@@ -843,12 +843,14 @@ def _restore_table_objects(
 
     @staticmethod
     def _restore_table_object(
-        context: BackupContext, db: Database, table: Table
+        context: BackupContext,
+        db: Database,
+        table: Table,
     ) -> None:
         try:
             if (
                 table.is_merge_tree()
-                or table.is_view()
+                or table.is_materialized_view()
                 or table.is_external_engine()
                 or table.is_distributed()
             ):
@@ -867,7 +869,7 @@ def _restore_table_object(
                 context.ch_ctl.create_table(table)
         except Exception as e:
             logging.debug(
-                f"Both table `{db.name}`.`{table.name}` restore methods failed. Removing it. Exception: {e}"
+                f"Failed to restore table `{db.name}`.`{table.name}`. Removing it. Exception: {e}"
             )
             if table.is_dictionary():
                 context.ch_ctl.drop_dictionary_if_exists(table)

images/clickhouse/entrypoint.py

@@ -12,7 +12,7 @@
 
     # In our test by default ch nodes have different root paths in the zookeeper(`/clickhouse01/` and `/clickhouse02/`).
     # So they are not connected to each other.
-    # If you need the same path for nodes, use `step_enable_shared_zookeeper_for_clickhouse` step to override configs. 
+    # If you need the same path for nodes, use `step_enable_shared_zookeeper_for_clickhouse` step to override configs.
     client.ensure_path("/{{ instance_name }}")
     client.ensure_path("/{{ conf.zk.shared_node }}")
 

tests/integration/features/table_engines.feature

@@ -178,6 +178,7 @@ Feature: Backup of tables with different engines and configurations
     And we got same clickhouse data at clickhouse01 clickhouse02
 
   @view
+  @require_version_23.3
   Scenario: Create backup containing views
     Given ClickHouse settings
     """
@@ -215,6 +216,10 @@ Feature: Backup of tables with different engines and configurations
     CREATE LIVE VIEW test_db.live_view
     AS SELECT n, n * n AS "n2"
     FROM test_db.table_01;
+
+    CREATE VIEW test_db.parametrized_view
+    AS WITH {a:UInt32} AS a, {b:UInt32} AS b
+    SELECT a + b
     """
     When we create clickhouse01 clickhouse backup
     Then we got the following backups on clickhouse01