Migrate tests to pytest #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nose has been deprecated and unmaintained for close to a decade now, and doesn’t work on Python 3.12. This migrates the tests and their runner to pytest. One set of parameterized tests was not executing due to a
returnwhere ayieldshould be, and I had to add a missing expected result to fix it, so this actually improves coverage!Most of the conversion was done mechanically with https://github.com/pytest-dev/nose2pytest, so you might want to skip that commit when reviewing (it can be recreated locally with
nose2pytest .).There are still a bunch of deprecation warnings left in the codebase and the six dependency should probably go, but this unblocked my current nose clean‐up work in Nixpkgs.