Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate scanner: more informative error messages #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starius
Copy link
Contributor

@starius starius commented Jul 28, 2015

Replace universal error message "Serialized regexp incompatible with your system" with more specific messages like "Bad MaxWordSize in serialized regexp. Expected ... Found ...".

Replace universal error message "Serialized regexp incompatible with
your system" with more specific messages like "Bad MaxWordSize in
serialized regexp. Expected ... Found ...".
@dprokoptsev
Copy link
Contributor

Your pull request surely might benefit from a motivation and rationale section.
I believe it's doing more harm than good at this point

Imagine yourself in your ops' shoes, receiving "Bad PtrSize..." error message from a arcane piece of software using pire you know next to nothing about -- how you're going to fix that not diving into pire internals? More generic error messages like "Incompatible regexp / Broken regexp / Regexp version mismatch" surely provide better diagnostics.

@starius
Copy link
Contributor Author

starius commented Jul 28, 2015

More generic error messages provide less information useful to debug. If a user gets this message and sends it to a developer, then the latter can't distinguish various possible sources of this problem.

Maybe better option is to provide both: "You are trying to used an incompatible version of a serialized regexp: value of field MAGIC is wrong. Expected X, found Y."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants