Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR checks #7

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Add PR checks #7

merged 8 commits into from
Dec 23, 2024

Conversation

kltsv
Copy link
Contributor

@kltsv kltsv commented Dec 20, 2024

Simplest PR checks: formatter, linter, tests.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@kltsv kltsv added the enhancement New feature or request label Dec 20, 2024
@kltsv kltsv self-assigned this Dec 20, 2024
@kltsv kltsv changed the title Add pr checks Add PR checks Dec 20, 2024
@kltsv kltsv requested review from wupididu and 2ZeroSix and removed request for wupididu December 20, 2024 16:57
Copy link

@2ZeroSix 2ZeroSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing mandatory, mostly "nice to have"

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
Copy link

@2ZeroSix 2ZeroSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kltsv kltsv merged commit f8a4e14 into main Dec 23, 2024
6 checks passed
@kltsv kltsv deleted the pr_checks branch December 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants