Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow content to fallback to snippet #143

Conversation

cognition9144
Copy link
Contributor

Some feeds only have summary but no content. However, according to the RSS 2.0 spec, it's totally valid. Fluent Reader should better the situation by falling back to snippet if no content

@yang991178
Copy link
Owner

The snippet field in the RSSItem object is simply the HTML text from content with tags stripped. Maybe you should take a look at the constructor of RSSItem to get the summary field from parsed feeds.

@cognition9144
Copy link
Contributor Author

Well, it's a bit tricky. rss-parser doesn't seem to parse the summary field of atom feeds. So I may need to send a PR there first.

@yang991178
Copy link
Owner

Well, it's a bit tricky. rss-parser doesn't seem to parse the summary field of atom feeds. So I may need to send a PR there first.

I remember you can declare additional property you want when initializing the parser. Maybe you can also switch the npm dependency to the original rss-parser package since we don't actually need any functionality from the custom one anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants