fix-redis-response-mem-leak (apache#2340)

Co-authored-by: wangxiaowei <wangxiaowei@bilibili.com>
yanglimingcn · Oct 31, 2023 · 6452525 · 6452525
1 parent 6b66cbe
commit 6452525
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/brpc/redis_reply.h b/src/brpc/redis_reply.h
@@ -318,7 +318,8 @@ inline void RedisReply::Swap(RedisReply& other) {
     std::swap(_length, other._length);
     std::swap(_data.padding[0], other._data.padding[0]);
     std::swap(_data.padding[1], other._data.padding[1]);
-    std::swap(_arena, other._arena);
+    // reply _arena should not be swapped because _arena point to address in redisresponse.
+    // std::swap(_arena, other._arena);
 }
 
 inline void RedisReply::CopyFromSameArena(const RedisReply& other) {