set the xmlns attribute for outer svg when scaling #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, what we get is not valid svg, and emacs won't render it While we're at it, don't set the height to 110% (not clear why this was done in the first place)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when scaling, we wrap the content of the svg (which is xml) in something that looks like
However, in order to be "valid svg" we need to specify the namespace:
xmlns="http://www.w3.org/svg".I suspect that some svg rendering libraries are a bit forgiving of this, and you are working with a file with an extension that ends in
.svgit will assume that's the namespace that you mean, but at least for me (emacs-maconMac OSX), things aren't so forgiving.To my eye, scaling with height set to 110% looked a little weird, and it looked better with 100% scaling, so I also changed that.