Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPS #60

Closed
boekkooi-lengoo opened this issue Jan 25, 2023 · 5 comments · Fixed by apache/apisix#8823
Closed

Support HTTPS #60

boekkooi-lengoo opened this issue Jan 25, 2023 · 5 comments · Fixed by apache/apisix#8823

Comments

@boekkooi-lengoo
Copy link

boekkooi-lengoo commented Jan 25, 2023

Good day,
I'm currently using the opentelemetry plugin in APISix in combination with Elastic APM which is served over https.
Sadly I can't seem to get this to work as the address gets prefixed with http:// in the http_client.

This results in the following error.

2023/01/25 10:55:29 [error] 51#51: *5451 [lua] http_client.lua:46: do_request(): request failed: Client sent an HTTP request to an HTTPS server.
, context: ngx.timer, client: 10.20.0.68, server: 0.0.0.0:9443

Is it possible to add support for https or at least only prefix the address when it contains no protocol?

Thanks in advance.

Related to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options and the env var OTEL_EXPORTER_OTLP_ENDPOINT

@yangxikun
Copy link
Owner

I will try to implement this feature.

@yangxikun
Copy link
Owner

@boekkooi-lengoo
Copy link
Author

Hey @yangxikun,
Thank for for having a look at this issue.
I think allowing the user to configure ssl_verify would be great, however in my case I don't need it 😄

yangxikun pushed a commit that referenced this issue Jan 30, 2023
yangxikun added a commit that referenced this issue Jan 30, 2023
feat: exporter client support https #60
yangxikun pushed a commit to yangxikun/apisix that referenced this issue Feb 9, 2023
yangxikun pushed a commit to yangxikun/apisix that referenced this issue Feb 10, 2023
@yangxikun
Copy link
Owner

apache/apisix#8823 is merged.

@boekkooi-lengoo
Copy link
Author

Hey @yangxikun,
Thank you for resolving this issue and even getting it into APISIX amazing 🥳!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants