-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Finder's NewWindowTarget option #206
base: main
Are you sure you want to change the base?
Conversation
I had an indentation error. I've fixed it. Could you retry the CI and merge this if it's good? :) |
Oh, looks like the |
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
The fact that we need 2 commands to change this settings breaks the architecture of the project which assumed 1 command was always sufficient. I will adapt the project architecture to be able to create these kind of complex commands. Thanks a lot for this PR anyways, I'll update it to merge when the project is ready. |
a7bc1a8
to
9feedb1
Compare
TODO:
Can somebody please check what values are set when the chosen option is "iCloud Drive" (it's disabled on my machine, so I can't check it myself)
I checked it with: