Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Transform Evaluator "decomposeDiacriticalMarks" #90

Closed
Semperverus opened this issue Sep 18, 2024 · 0 comments
Closed

Implement Transform Evaluator "decomposeDiacriticalMarks" #90

Semperverus opened this issue Sep 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Semperverus
Copy link
Contributor

Semperverus commented Sep 18, 2024

Is your feature request related to a problem? Please describe.
decomposeDiacriticalMarks is crucial for systems that only accept ASCII or limited characters, such as On-Premises ActiveDirectory or LDAP setups.

Describe the solution you'd like
Review, correct (if necessary), and implement Update TransformEvaluator.ts to include decomposeDiacriticalMarks #89 pull request

The behavior should mimick the behavior outlined in the official SailPoint developer documentation.

Describe alternatives you've considered
An alternative would be for yannick to write this same function in the way they see fit (most likely will be of higher quality than my code).

Additional context
This is needed for much of the work I am doing. While I did put effort into trying to understand the existing code to the best of my abilities, I am not great at JavaScript and am hoping yannick can review this code and possibly fix it if/where needed.

@Semperverus Semperverus added the enhancement New feature or request label Sep 18, 2024
@Semperverus Semperverus changed the title Implement Transform Evaluator "decomposeDiacriticalMarks Implement Transform Evaluator "decomposeDiacriticalMarks" Sep 19, 2024
yannick-beot-sp added a commit that referenced this issue Oct 9, 2024
- Add User Agent
- Add transform evaluation support for `decomposeDiacriticalMarks` (cf. [#90](#90)) by [@Semperverus](https://github.com/Semperverus)
- Add new command to enable logging
- Fixed dependency (axios, micromatch)
- Refactored code due to [#36](sailpoint-oss/typescript-sdk#36)
- Removed Workflow Tester view due to webview-ui-toolkit deprecation (cf. microsoft/vscode-webview-ui-toolkit#561)
- Add support for Applications
- Error with session management (cf. [#93](#93))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant