-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复商家转账参数缺失的问题 #977
Merged
Merged
fix: 修复商家转账参数缺失的问题 #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pay-yansongda canceled.
|
是有这个问题,单测方便一起补一下么? |
yansongda
requested changes
May 8, 2024
@@ -90,15 +90,15 @@ protected function normal(array $params, array $config, Collection $payload): ar | |||
*/ | |||
protected function encryptSensitiveData(array $params, array $config, Collection $payload): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改为以下代码吧
protected function encryptSensitiveData(array $params, array $config, Collection $payload): array
{
$data['transfer_detail_list'] = $payload->get('transfer_detail_list', []);
$data['_serial_no'] = get_wechat_serial_no($params);
$publicKey = get_wechat_public_key($config, $data['_serial_no']);
foreach ($data['transfer_detail_list'] as $key => $list) {
if (!empty($list['user_name'])) {
$data['transfer_detail_list'][$key]['user_name'] = encrypt_wechat_contents($list['user_name'], $publicKey);
}
}
return $data;
}
然后帮忙把单测补充一下
yansongda
approved these changes
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
============================================
- Coverage 97.51% 97.50% -0.02%
Complexity 907 907
============================================
Files 347 347
Lines 6268 6201 -67
============================================
- Hits 6112 6046 -66
+ Misses 156 155 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前会丢失所有除了user_name之外的所有参数....
很好奇为什么之前没人发现