Fix build error at Node.js v12 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems only success at v10 and above at travis... |
|
I don’t know how to fix this problem; Maybe a better PR is more suitable for solving this issue. |
|
I deleted package-lock.json because it is not in sync with package.json, thus crash the build. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaration: I have absolute 0 experience with C/C++ programming before this.
But this branch will build successfully at Node.js v12.3.1 at macOS 10.14.6
probably related to #131
reference:
tree-sitter/tree-sitter-bash@97e13b8
fsevents/fsevents#274
nodejs/nan#849
https://github.com/nodejs/nan/blob/master/doc/converters.md
https://v8docs.nodesource.com/node-0.8/dc/d0a/classv8_1_1_value.html#a646846ac3a30fcc1477bc4727a3d4a59